Imp upload command #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
pacoyang
commented
Dec 6, 2023
pacoyang
commented
- Add support for selecting external EVM account
- Add support for prompting for the project name
- New spinner
Leechael
reviewed
Dec 7, 2023
Comment on lines
180
to
184
| if (endpoint === 'wss://poc6.phala.network/ws') { | ||
| brickProfileFactoryContractId = '0x4a7861f257568a989a9c24db60981efb745d134a138203a219da051337428b49' | ||
| } else if (endpoint === 'wss://poc5.phala.network/ws') { | ||
| brickProfileFactoryContractId = '0x489bb4fa807bbe0f877ed46be8646867a8d16ec58add141977c4bd19b0237091' | ||
| } else if (endpoint === 'wss://api.phala.network/ws') { | ||
| brickProfileFactoryContractId = '0xb59bcc4ea352f3d878874d8f496fb093bdf362fa59d6e577c075f41cd7c84924' | ||
| } else { |
There was a problem hiding this comment.
We should using a separate configuration file.
src/lib/PhatBaseCommand.ts
Outdated
Comment on lines
312
to
354
| async promptEvmAccountId({ | ||
| contract, | ||
| cert, | ||
| }: { | ||
| contract: BrickProfileContract, | ||
| cert: CertificateData, | ||
| }) { | ||
| try { | ||
| this.action.start('Querying your external accounts') | ||
| const { output } = await contract.query.getAllEvmAccounts(cert.address, { | ||
| cert, | ||
| }) | ||
|
|
||
| } catch (error: any) { | ||
| ux.action.stop(chalk.red('Failed to compile.\n')) | ||
| return this.error(error) | ||
| if (output.isErr) { | ||
| throw new Error(output.asErr.toString()) | ||
| } | ||
| if (output.asOk.isErr) { | ||
| throw new Error(output.asOk.asErr.toString()) | ||
| } | ||
| const accounts = output.asOk.asOk.map((i) => { | ||
| const obj = i.toJSON() | ||
| return { | ||
| id: obj.id, | ||
| address: obj.address, | ||
| rpcEndpoint: obj.rpc, | ||
| } | ||
| }) | ||
| this.action.stop() | ||
| const { account } = await inquirer.prompt({ | ||
| name: 'account', | ||
| message: 'Please select an external account:', | ||
| type: 'list', | ||
| choices: accounts.map(account => ({ | ||
| name: `${account.address}. ${chalk.dim(account.rpcEndpoint)}`, | ||
| value: account.id, | ||
| })), | ||
| }) | ||
| return account | ||
| } catch (error) { | ||
| this.action.fail('Failed to query your external accounts.') | ||
| return this.error(error as Error) | ||
| } | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.